[Atul Teja Vellampalli] iP #9

Atulteja · 2024-08-30T14:22:12Z

No description provided.

…e list

…e and ran the tests

hzxnancy

Good job on OOP! The code is neat with good variable names and personalisation However, do take note of the length of characters in a single line.

hzxnancy · 2024-09-04T04:31:49Z

src/main/java/JeM.java

+        System.out.println(" Hello! I'm JeM, Your e-Assistant");
+        System.out.println(" Personal To-Do list bot! ");
+        System.out.println(" Just type out your tasks you have to complete and I will make a list of them for you.");
+        System.out.println(" Type 'list' to see the current list of tasks, and type 'delete <task number>' to delete that task.");
+        System.out.println(" Finally, type 'bye' to end the chat!");


I like how you provided instructions for using this chatbot

hzxnancy · 2024-09-04T04:39:09Z

src/main/java/Storage.java

+        int index = 0;
+            for (Task task : taskList) {
+                if (task instanceof Deadline) {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task + " (by: " + ((Deadline) task).getDeadline() + ")");


Perhaps you could do some line wrapping?

hzxnancy · 2024-09-04T04:41:00Z

src/main/java/Storage.java

+            for (Task task : taskList) {
+                if (task instanceof Deadline) {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task + " (by: " + ((Deadline) task).getDeadline() + ")");
+                }else if (task instanceof Event) {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task + " (from: " + ((Event) task).getStart() + " to: " + ((Event) task).getEnd() + ")");
+                }else {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task);
+                }
+                index++;
+            }


Extra indentation found here

hzxnancy · 2024-09-04T04:45:58Z

src/main/java/JeM.java

+        while (true) {
+            String line = scanner.nextLine().trim();
+
+            if (line.equalsIgnoreCase("bye")) {
+                System.out.println("Bye. Hope to see you again soon!");
+                break;
+            }
+
+            handleInput(line, storage);
+        }


Would it be better to extract this function for better abstraction?

hzxnancy · 2024-09-04T04:48:56Z

src/main/java/JeM.java

+            handleInput(line, storage);
+        }
+
+        System.out.println("____________________________________________________________");


It will be better if you could extract this line of code to create a printLine() method, so you wouldn't have to copy and paste this line throughout the code.

DarkDragoon2002 · 2024-09-04T04:53:14Z

src/main/java/Deadline.java

@@ -0,0 +1,17 @@
+public class Deadline extends Task{


Good coding practices for this file and proper naming conventions followed.
However, it could use more comments for this file, but the code is clean and easy to understand.

DarkDragoon2002 · 2024-09-04T04:55:09Z

src/main/java/Event.java

@@ -0,0 +1,25 @@
+public class Event extends Task{


Clean Code and proper naming conventions. However, there is unnecessary code that is commented out that can be deleted. Some comments can be added but the code is very clean and can be understood very easily.

DarkDragoon2002 · 2024-09-04T15:34:41Z

src/main/java/JeM.java

+
+        System.out.println("____________________________________________________________");
+
+        System.out.println(" Hello! I'm JeM, Your e-Assistant");


Was a cute touch that you added instructions for the chatbot

DarkDragoon2002 · 2024-09-04T15:35:41Z

src/main/java/JeM.java

+            handleInput(line, storage);
+        }
+
+        System.out.println("____________________________________________________________");


Would be better to either create a lineMessage() method or a String constant to neaten up the code

DarkDragoon2002 · 2024-09-04T15:37:19Z

src/main/java/JeM.java

+        Task task = new Event(taskContent, start, end);
+        storage.storageInsert(task);
+    }
+}


Code while being self explanatory could still use some comments on what some methods do

DarkDragoon2002 · 2024-09-04T15:38:43Z

src/main/java/Storage.java

+        int index = 0;
+            for (Task task : taskList) {
+                if (task instanceof Deadline) {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task + " (by: " + ((Deadline) task).getDeadline() + ")");
+                }else if (task instanceof Event) {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task + " (from: " + ((Event) task).getStart() + " to: " + ((Event) task).getEnd() + ")");
+                }else {
+                    System.out.println((index + 1) + "." + task.getStatusIcon() + " " + task);
+                }
+                index++;
+            }
+    }
+
+}


indentation is a bit off, please do check again

…hanges

joshuan98 · 2024-09-16T11:52:42Z

src/main/java/app/JeM.java

+
+import java.util.Scanner;
+
+public class JeM {


You can consider using Jem instead to follow the PascalCase class naming format.

joshuan98 · 2024-09-16T11:53:32Z

src/main/java/app/JeM.java

+        } else if (line.toLowerCase().startsWith("delete")) {
+            handleDeleteCommand(line, storage);
+        } else if (line.toLowerCase().startsWith("unmark")) {
+            handleUnmarkCommand(line, storage);
+        } else if (line.toLowerCase().startsWith("mark")) {
+            handleMarkCommand(line, storage);
+        } else if (line.toLowerCase().startsWith("todo")) {
+            handleTodoCommand(line, storage);
+        } else if (line.toLowerCase().startsWith("deadline")) {
+            handleDeadlineCommand(line, storage);
+        } else if (line.toLowerCase().startsWith("event")) {
+            handleEventCommand(line, storage);


.toLowerCase() seems to be used repetitively here. A switch case may be used instead.

joshuan98 · 2024-09-16T11:56:42Z

src/main/java/taskmanager/Storage.java

+        if (task instanceof Deadline) {
+            System.out.print(" (by: " + ((Deadline) task).getDeadline() + ")");
+        } else if (task instanceof Event) {
+            System.out.print(" (from: " + ((Event) task).getStart() + " to: " + ((Event) task).getEnd() + ")");


You can consider splitting this line to not reach the max character limit of 120.

Merged branch-Level-8 with master

branch-Level-9 merge

added JavaDoc documentation

… UI code

damithc and others added 12 commits August 19, 2024 22:26

Updated the Duke.java file to JeM.java

f6011f1

Edited Duke.java file into JeM.java

0250b0c

Updated the Duke.java file to JeM.java

4e53c96

Merge branch 'master' of https://github.com/Atulteja/ip

74035b6

Added the echo functionality

bdfca0d

Added the list feature where the user can add/delete and also view th…

d8152a2

…e list

Added the mark and unmark features for the list

3313759

Edited the variables and function names to match the coding standard

d67e294

Added a task class to encapsulate the incoming tasks

ad9ff3a

Added the todo, deadline and event features

d06936a

Updated the EXPECTED.txt file, input.txt file and the runtest.bat fil…

1916d94

…e and ran the tests

Updated the code quality and refactored by JeM file

8814920

hzxnancy reviewed Sep 4, 2024

View reviewed changes

DarkDragoon2002 reviewed Sep 4, 2024

View reviewed changes

Atulteja added 9 commits September 7, 2024 12:41

Addressed comments brought up doing PR review, made the appropriate c…

55fbcbb

…hanges

Made a custom exception to handle invalid commands

d49cfe2

Added error handling for all actions

641976f

Merge Level-5 into master

4ec858d

Added packaging to the classes

973e5e1

Merge A-Packages into master

6fe6ac0

bugfixes

faa55c9

Already been using collection classes from the start

3144b66

Already had a delete function, added a clear list function

5dca82c

joshuan98 reviewed Sep 16, 2024

View reviewed changes

Atulteja added 6 commits September 18, 2024 17:24

Added file save and loading features

805bc87

Merge branch 'Level-6', added a clear fucntion

4fd9117

Merged Level-7

6fd68a8

Made the Jar file and made some bugfixes

77295e3

Made some bugfixes

98678c9

Added parser, Ui and command classes

98f65b7

Atulteja and others added 14 commits September 28, 2024 14:25

branch-Level-8

8aff368

branch-Level-9

2f8644e

Merge pull request #1 from Atulteja/branch-Level-8

670cd4a

Merged branch-Level-8 with master

conflicts resolved

9b6cd5b

Merge pull request #2 from Atulteja/branch-Level-9

24714e3

branch-Level-9 merge

bug fixes

4f4c7ab

added JavaDoc documentation

3204369

Merge pull request #3 from Atulteja/branch-A-JavaDoc

911b569

added JavaDoc documentation

Updated the README page

b292dfe

final bugfixes and changes

d0569d1

updated README

70f8401

Renamed some variables

bff8663

Made changes to the packaging and some minor code improvements to the…

8345029

… UI code

fixed some bugs

4d9f287

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Atul Teja Vellampalli] iP #9

[Atul Teja Vellampalli] iP #9

Atulteja commented Aug 30, 2024

hzxnancy left a comment

hzxnancy Sep 4, 2024

hzxnancy Sep 4, 2024

hzxnancy Sep 4, 2024

hzxnancy Sep 4, 2024

hzxnancy Sep 4, 2024

DarkDragoon2002 Sep 4, 2024

DarkDragoon2002 Sep 4, 2024

DarkDragoon2002 Sep 4, 2024

DarkDragoon2002 Sep 4, 2024

DarkDragoon2002 Sep 4, 2024

DarkDragoon2002 Sep 4, 2024

joshuan98 Sep 16, 2024

joshuan98 Sep 16, 2024

joshuan98 Sep 16, 2024


		System.out.println("____________________________________________________________");

		System.out.println(" Hello! I'm JeM, Your e-Assistant");

[Atul Teja Vellampalli] iP #9

Are you sure you want to change the base?

[Atul Teja Vellampalli] iP #9

Conversation

Atulteja commented Aug 30, 2024

hzxnancy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment