Fix feed, fix feed item sorting #1769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66c8888 (nushell#1765) added old blog posts but with a current author and commit date. Blog items should be dated to their creation and publication rather than when this git source move took place. Because the feed plugin used git dates, only the 30 oldest items ended up in the feed. Falling back to front-matter date should resolve the issue. Blog posts showing up correctly dated on `/blog/` indicates that the page date is set correctly from the file name, even without explicit front matter within the post source file. Untested; please verify. Hopefully resolves nushell#1767 An alternative approach would be committing the post files individually with git commits dated back to their publication dates. But the whole git integration seems error-prone to me, so this commit seems like a better solution with less effort.
|
Were you able to test this locally? The main reason I didn't test was that RSS feeds aren't working in the local dev server for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
66c8888 (#1765) added old blog posts but with a current author and commit date.
Blog items should be dated to their creation and publication rather than when this git source move took place.
Because the feed plugin used git dates, only the 30 oldest items ended up in the feed.
Falling back to front-matter date should resolve the issue.
Blog posts showing up correctly dated on
/blog/indicates that the page date is set correctly from the file name, even without explicit front matter within the post source file.Untested; please verify.
Hopefully resolves #1767
An alternative approach would be committing the post files individually with git commits dated back to their publication dates. But the whole git integration seems error-prone to me, so this commit seems like a better solution with less effort.