User authentication using OpenID Connect #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return errors.New("auth init failure") | ||
| } | ||
|
|
||
| redirectUrl := a.oauth2Config.AuthCodeURL("TODO:STATE") |
Check failure
Code scanning / CodeQL
Use of constant `state` value in OAuth 2.0 URL High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 months ago
To fix the problem, we need to replace the constant state value with a unique, non-guessable value for each authentication request. This can be achieved by generating a random state value using a secure random number generator and encoding it. Additionally, we should store this state value in a way that it can be validated later during the callback to ensure it matches the original request.
- Generate a unique state value: Create a function to generate a random state value using
crypto/randand encode it usingbase64.URLEncoding. - Store the state value: Store the generated state value in a cookie or session to validate it later during the callback.
- Validate the state value: During the callback, retrieve and validate the state value to ensure it matches the original request.
Suggested changeset
1
api/auth.go
| @@ -123,3 +123,4 @@ | ||
|
|
||
| redirectUrl := a.oauth2Config.AuthCodeURL("TODO:STATE") | ||
| state := generateStateOauthCookie(c.Response()) | ||
| redirectUrl := a.oauth2Config.AuthCodeURL(state) | ||
| // Check redirect URL to prevent invalid/recursive redirects | ||
| @@ -141,2 +142,8 @@ | ||
| } | ||
| // Validate state | ||
| stateCookie, err := c.Cookie("oauthstate") | ||
| if err != nil || stateCookie.Value != httpRequest.URL.Query().Get("state") { | ||
| log.Logger.Warn().Err(err).Msg("Invalid state parameter") | ||
| return c.NoContent(http.StatusUnauthorized) | ||
| } | ||
| // Check if the user is authenticated | ||
| @@ -179 +186,19 @@ | ||
| } | ||
|
|
||
| func generateStateOauthCookie(w http.ResponseWriter) string { | ||
| b := make([]byte, 16) | ||
| _, err := rand.Read(b) | ||
| if err != nil { | ||
| log.Logger.Error().Err(err).Msg("Failed to generate random state") | ||
| return "" | ||
| } | ||
| state := base64.URLEncoding.EncodeToString(b) | ||
| http.SetCookie(w, &http.Cookie{ | ||
| Name: "oauthstate", | ||
| Value: state, | ||
| Expires: time.Now().Add(10 * time.Minute), | ||
| HttpOnly: true, | ||
| Path: "/", | ||
| }) | ||
| return state | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.