Skip to content

Commit

Permalink
fixup!(ci): Run create-dmg until it succeeds
Browse files Browse the repository at this point in the history
This properly stores the result of the increment operation in a
variable, where previously that evaluation could return 1 and mess up
with the exit status of this build step.

That would happen when create-dmg failed in the first try, but succeeded
in the next one.

I've also added "set -x" to enable Bash's command tracing, making it
easier to spot how many times create-dmg gets invoked.
  • Loading branch information
guihkx committed Oct 20, 2024
1 parent 79170cc commit 75c876e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ jobs:
- name: Build dmg (${{ matrix.build-type }})
run: |
set -x
cd build
# FIXME: Undo this overengineered crap once the following issue gets figured out:
# https://github.com/actions/runner-images/issues/7522
Expand All @@ -211,7 +212,7 @@ jobs:
echo 'Error: create-dmg did not succeed even after 10 tries.'
exit 1
fi
((i++))
i=$((i+1))
done
- name: Notarize
Expand Down

0 comments on commit 75c876e

Please sign in to comment.