Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Remove low resolution icons #649

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

guihkx
Copy link
Collaborator

@guihkx guihkx commented Sep 5, 2023

This is just an aesthetical change.

Long story short:

AppImages have a default icon. For some reason, our AppImage-making tool always chooses the lowest resolution icon we have (16x16) as the default one, and there's no way to specify a different icon (AFAIK).

End result: Our AppImage icon looks really bad on file managers that support previewing AppImage files via libappimage, like Dolphin.

Quick and dirty solution: Keep only icons that are 128x128 and above.

Comparison:

image

@guihkx guihkx force-pushed the delete-low-res-linux-icons branch from 38bf5f2 to fbc4a7c Compare September 5, 2023 19:13
@nuttyartist
Copy link
Owner

Won't we need the lower ones for the system tray?

@guihkx
Copy link
Collaborator Author

guihkx commented Sep 5, 2023

No. We actually use the 1024x1024 icon for the tray icon here:

notes/src/mainwindow.cpp

Lines 522 to 535 in 70ee81f

void MainWindow::setupTrayIcon()
{
#if !defined(Q_OS_MAC)
auto trayIconMenu = new QMenu(this);
trayIconMenu->addAction(m_restoreAction);
trayIconMenu->addSeparator();
trayIconMenu->addAction(m_quitAction);
m_trayIcon->setContextMenu(trayIconMenu);
#endif
QIcon icon(QStringLiteral(":images/notes_system_tray_icon.png"));
m_trayIcon->setIcon(icon);
m_trayIcon->show();
}

And I think Qt takes care of resizing the icon for us.

This is just an aesthetical change.

Long story short:

AppImages have a default icon. For some reason, our AppImage-making
tool always chooses the lowest resolution icon we have (16x16) as the
default one, and there's no way to specify a different icon (AFAIK).

End result: Our AppImage icon looks really bad on file managers that
support previewing AppImage files via libappimage, like Dolphin.

Quick and dirty solution: Keep only icons that are 128x128 and above.
@guihkx guihkx force-pushed the delete-low-res-linux-icons branch from fbc4a7c to 10bed34 Compare September 5, 2023 20:19
@guihkx guihkx merged commit 10bed34 into nuttyartist:master Sep 5, 2023
1 check passed
@guihkx guihkx deleted the delete-low-res-linux-icons branch September 5, 2023 20:39
@nuttyartist
Copy link
Owner

Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants