CI: Only download required build artifacts to make the Windows installer #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are breaking changes[1], but none of them really applies to us. [1] https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
Our Windows CI has a separate build job with the sole purpose of creating an installer, by joining three different Windows builds: - Qt5: x86 and x86_64 - Qt6: x86_64 To accomplish that, this job needs to download these build artifacts from previous jobs. Until now, we would download all build artifacts, including ones from unrelated jobs such as Linux and macOS, which doesn't make sense, as it's wasteful and slow. Thankfully, version 4.1.0[1] of 'actions/download-artifact' now allows us to specify which artifacts to download, which is what this commit does. [1] https://github.com/actions/download-artifact/releases/tag/v4.1.0
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Windows CI has a separate build job with the sole purpose of creating an installer, by joining three different Windows builds:
To accomplish that, this job needs to download these build artifacts from previous jobs.
Until now, we would download all build artifacts, including ones from unrelated jobs such as Linux and macOS, which doesn't make sense, as it's wasteful and slow.
Thankfully, version 4.1.0 of
actions/download-artifactnow allows us to specify which artifacts to download, which is what this pull request does.