CI/Windows: Work around unset VCToolsRedistDir environment variable
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the "vcvarsall.bat" batch script from VS 2019 has stopped defining the VCToolsRedistDir environment variable, for reasons unknown so far [1]. We rely on that variable in CI to copy MSVC runtime DLLs to our Windows packages, so this adds a workaround for when that variable is not set. [1] actions/runner-images#10819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the
vcvarsall.batbatch script from VS 2019 has stopped defining theVCToolsRedistDirenvironment variable, for reasons unknown so far.We rely on that variable in CI to copy MSVC runtime DLLs to our Windows packages, so this adds a workaround for when that variable is not set.