Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/macOS: Run create-dmg as root #712

Merged
merged 1 commit into from
Oct 20, 2024
Merged

CI/macOS: Run create-dmg as root #712

merged 1 commit into from
Oct 20, 2024
+3 −1

Conversation

guihkx
Copy link
Collaborator

@guihkx guihkx commented Oct 20, 2024

Fixes #711 (hopefully).

@guihkx
Copy link
Collaborator Author

guihkx commented Oct 20, 2024

No errors in this particular CI run on macOS. This "fix" looks promising, but only time will tell...

@nuttyartist Are you okay with this?

@nuttyartist
Copy link
Owner

Let's give it a shot. Is there a major downside to using root here?

@guihkx
Copy link
Collaborator Author

guihkx commented Oct 20, 2024 •
edited
Loading

Is there a major downside to using root here?

Well, we already give create-dmg full control over our macOS binaries even without root, so I don't think root will have any meaningful impact here. Besides, by using create-dmg we effectively trust it.

@nuttyartist
Copy link
Owner

Gotcha 👍

@guihkx guihkx merged commit 2d759ce into nuttyartist:master Oct 20, 2024
17 checks passed
@guihkx guihkx deleted the create-dmg-as-root branch October 20, 2024 05:50
@guihkx guihkx mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD OS: MacOS X
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do something about flaky macOS builds
2 participants
@guihkx @nuttyartist