Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5 branch] CI: Only generate Qt 5 build artifacts #718

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

guihkx
Copy link
Collaborator

@guihkx guihkx commented Oct 25, 2024

We're on the "qt5" branch, it doesn't make sense to generate Qt 6 build artifacts anymore.

This also drops the x64 build for Windows, leaving only the x86 build.

This dependency is necessary to build the pyzstd wheel, as they stopped
providing a pre-built wheel for Python 3.8 after they released 0.16.2.
@guihkx guihkx added the CI/CD label Oct 25, 2024
@guihkx
Copy link
Collaborator Author

guihkx commented Oct 25, 2024

Hmm, I should also add a restriction to prevent the Qt 5 CI/CD from running when pushing tags...

I think we can still allow it to run when v2.3.* tags are pushed, right?

@guihkx guihkx changed the title [qt5 branch] Only generate Qt 5 build artifacts [qt5 branch] CI: Only generate Qt 5 build artifacts Oct 25, 2024
@nuttyartist
Copy link
Owner

We're on the "qt5" branch, it doesn't make sense to generate Qt 6 build artifacts anymore.

👍

This also drops the x64 build for Windows, leaving only the x86 build.

👍

I think we can still allow it to run when v2.3.* tags are pushed, right?

Yep.

We're on the "qt5" branch, it doesn't make sense to generate Qt 6 build
artifacts anymore.

This also drops the x64 build for Windows, leaving only the x86 build.
@guihkx guihkx force-pushed the qt5-stop-building-qt6 branch from ca4ac29 to 75bd647 Compare October 25, 2024 12:04
@guihkx guihkx merged commit 75bd647 into nuttyartist:qt5 Oct 25, 2024
7 checks passed
@guihkx guihkx deleted the qt5-stop-building-qt6 branch October 25, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants