refactor: replace non-empty QString constructors with QStringLiteral() #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Integral-Tech Thanks for your contribution! Can you run the clang-formatter on mainwindow.cpp? |
|
Yeah, I was planning on doing that, thanks @Integral-Tech! |
Integral-Tech
force-pushed
the
qstring-refactor
branch
from
05cd836 to
8fd05b5
Compare
I have just run clang-format and submitted a new commit :) |
zjeffer
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QStringLiteral(), which makes constructing QString objects from string literals more efficient.