Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task-NXDOC-2686-Document-Amazon-DocumentDB #2264

Open
wants to merge 2 commits into
base: 2023
Choose a base branch
from

Conversation

NourNuxeo
Copy link
Contributor

No description provided.

@NourNuxeo NourNuxeo requested review from bdelbosc and kevinleturc July 8, 2024 17:02
Copy link
Member

@bdelbosc bdelbosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rewrite the page with the following layout

DocumentDB is compatible with MongoDB therefor it can be used by Nuxeo like a MongoDB backend,
but there are limitations.

Limitations

  • fulltext search using repository ... you need to rely on elastic, this requires to disable ...
  • retryable writes ... this require to use the option ...
  • cursor ... can we do something to increase the limit ?

Note there are also other differences that should not affect Nuxeo, please refer to DocumentDB

Configuration

To use DocumentDB you need the following options

..templates=mongodb
nuxeo.vcs.fulltext.search.disabled=true
nuxeo.mongodb.server=<MONGO_URL?retryWrites=false

@NourNuxeo NourNuxeo force-pushed the task-NXDOC-2686-Document-Amazon-DocumentDB branch from 00ca715 to c323d5c Compare July 9, 2024 15:26
@NourNuxeo NourNuxeo requested a review from bdelbosc July 9, 2024 15:33
@NourNuxeo NourNuxeo force-pushed the task-NXDOC-2686-Document-Amazon-DocumentDB branch from c323d5c to 1fbc0bb Compare July 9, 2024 15:42
kevinleturc
kevinleturc previously approved these changes Jul 10, 2024
@NourNuxeo NourNuxeo force-pushed the task-NXDOC-2686-Document-Amazon-DocumentDB branch from 1fbc0bb to e5425f4 Compare July 11, 2024 16:47
@NourNuxeo NourNuxeo requested a review from bdelbosc July 11, 2024 16:48
bdelbosc
bdelbosc previously approved these changes Jul 15, 2024
@NourNuxeo NourNuxeo requested a review from manonlumeau July 15, 2024 13:31
@NourNuxeo NourNuxeo marked this pull request as ready for review July 15, 2024 13:31
@NourNuxeo NourNuxeo force-pushed the task-NXDOC-2686-Document-Amazon-DocumentDB branch 2 times, most recently from a94a778 to 1ae7f1c Compare August 14, 2024 16:03
@NourNuxeo NourNuxeo requested a review from bdelbosc August 14, 2024 16:06
bdelbosc
bdelbosc previously approved these changes Aug 20, 2024
Copy link

@Prosune Prosune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NourNuxeo I have suggested some changes. If they look fine, please approve or provide your feedback.

tree_item_index: 700

---
`DocumentDB` is compatible with `MongoDB`, therefore, it can be used by `Nuxeo` like a `MongoDB` backend,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested text - DocumentDB is compatible with MongoDB, which allows Nuxeo to use DocumentDB as a backend for MongoDB.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but DocumentDB is not a backend for MongoDB. maybe to Use DocumentDB as a backend like MongoDB.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a language perspective, I would suggest the following statement:
DocumentDB is compatible with MongoDB. Therefore, it can be used by Nuxeo as a backend database, like MongoDB.

Copy link
Contributor Author

@NourNuxeo NourNuxeo Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my reflection is the following counter-example:

postgresql can be used as a backend database, like mongodb
postgresql cannot be used like a mongodb backend (more specific and shorter)

so this seems to be the best fit to me:

documentdb can be used like a mongodb backend 

@NourNuxeo
Copy link
Contributor Author

NourNuxeo commented Aug 21, 2024

@Prosune Thank you for your feedback.
Before getting into it, could you please follow this workflow:
let the author do the review requests so he can have a chance to implement/discuss/reject (some of the?) suggestions before asking everybody to check again ? This avoids prematurely requesting people.

@Prosune
Copy link

Prosune commented Aug 22, 2024

@Prosune Thank you for your feedback. Before getting into it, could you please follow this workflow: let the author do the review requests so he can have a chance to implement/discuss/reject (some of the?) suggestions before asking everybody to check again ? This avoids prematurely requesting people.

@NourNuxeo Thank you for the suggestion. I am looking for such feedback as I am planning to improve the documentation process. If you have more such suggestions to improve the documentation process, please do share.

@NourNuxeo NourNuxeo force-pushed the task-NXDOC-2686-Document-Amazon-DocumentDB branch 2 times, most recently from b4b3792 to dab7737 Compare August 23, 2024 12:19
@NourNuxeo NourNuxeo requested review from bdelbosc and removed request for kevinleturc August 23, 2024 12:34
@NourNuxeo NourNuxeo force-pushed the task-NXDOC-2686-Document-Amazon-DocumentDB branch from dab7737 to 565c9f7 Compare August 26, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants