BDE-226 added development mode feature flags for 'studio-package-name…

…' at first
nuxeo · Mar 26, 2024 · 8c38f66 · 8c38f66
1 parent 222294b
commit 8c38f66
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/src/main/runtime-build-info.js b/src/main/runtime-build-info.js
@@ -39,6 +39,7 @@ class DevelopmentMode extends ServiceWorkerComponent {
   constructor(worker, isEnabled) {
     super(worker);
     this._isEnabled = isEnabled;
+    this._featureFlags = {};
 
     // bind this methods
     Object.getOwnPropertyNames(Object.getPrototypeOf(this))
@@ -59,13 +60,28 @@ class DevelopmentMode extends ServiceWorkerComponent {
     this._isEnabled = !this._isEnabled;
   }
 
+  setFeatureFlag(flag, value) {
+    this._featureFlags[flag] = value;
+  }
+
+  isFeatureFlagSet(flag) {
+    if (!this._featureFlags[flag]) {
+      return false;
+    }
+    return this._featureFlags[flag];
+  }
+
+  toggleFeatureFlag(flag) {
+    this._featureFlags[flag] = !this._featureFlags[flag];
+  }
+
   asConsole() {
-    return this.asPromise();
+    return this.asPromise()
       .then(() => console)
       .catch(() => {
         const noop = () => {};
         return {
-          log: noop, error: noop, warn: noop, info: noop,
+          log: noop, error: noop, warn: noop, info: noop
         };
       });
   }

diff --git a/src/main/service-worker.js b/src/main/service-worker.js
@@ -57,7 +57,8 @@ class ServiceWorkerMessageHandler extends ServiceWorkerComponent {
         .asConsole()
         .then((console) => console
           .log(`ServiceWorkerMessageHandler.handle(${JSON.stringify(request)}) called`));
-      return component[request.action](...request.params)
+      return component.asPromise()
+        .then((componentInstance) => componentInstance[request.action](...request.params))
         .then((response) => this.worker.developmentMode
           .asConsole()
           .then((console) => console
@@ -69,8 +70,7 @@ class ServiceWorkerMessageHandler extends ServiceWorkerComponent {
             .asConsole()
             .then((console) => console
               .log(`${JSON.stringify(response)} <- ServiceWorkerMessageHandler.handle(${JSON.stringify(request)})`, cause.stack));
-          return Promise
-            .resolve(response);
+          return response;
         });
     };
 

diff --git a/src/popup/index.js b/src/popup/index.js
@@ -213,6 +213,14 @@ function loadPage(worker) {
         // reset jQuery event handlers
         $('body').find('*').addBack().off();
 
+        // update the page according to the feature flags
+        pendingPromises.push(worker.developmentMode
+          .isFeatureFlagSet('studio-package-name')
+          .then((isEnabled) => {
+            if (isEnabled) return;
+            $('#studio-package-name-input').remove();
+          }));
+
         // process the page
         const browserVendor = worker.buildInfo.browserVendor();
         if (browserVendor === 'Firefox') {