-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest v3 migration #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nxmatic
commented
Mar 11, 2024
•
edited
Loading
edited
- error after loading the extension, server displayed connected but connection error in javascript [done]
- still miss-understanding of the extension activation, the icon is still not displayed grey when no tabs active [done]
- not authenticated on livepreview should mention 'not authenticated on studio' , lower font, disable button [done]
- livepreview redirect do not play (the url is not correctly defined) [done]
- livepreview, error message not handled [done]
- rename nuxeoWebException into nuxeoBrowserExtension [maybe]
- broken server restart typo in chrome action function [done]
- typo in server-connector check connected [done]
- about link broken [done]
- in query results, it seems the documents are duplicated, but in fact that multiple version [maybe]
- nxql query errors when searching [?] [maybe]
- in query form the clear button has an hover displayed at the wrong place (X) [maybe]
- in query form when entering the enter key, the popup is reset [maybe]
- nuxeo not registered are stated connectable [done]
- feature flag for studio project selection [blocker]
- manage button activation by features (studio, nuxeo, et studio authenticated) [done]
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
2 times, most recently
from
March 11, 2024 11:54
2b20020
to
b1a0a1f
Compare
…d libs from node_modules * updated dependencies * splitted app from transpilled files (babel) * imported libs from dependencies * allow using local connect (let's use the URL protocol) * ...
* moving from backround page to service worker * always call service worker components from popup pages
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
from
March 11, 2024 19:55
b1a0a1f
to
34cb624
Compare
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
3 times, most recently
from
March 19, 2024 14:07
1cb6d37
to
e883610
Compare
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
8 times, most recently
from
March 25, 2024 16:56
ac8d38e
to
ab6bba7
Compare
- convert response into an empty JSON object in connector
- defined version from package.json - injected built version in dotenv - generated manifest version according to
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
2 times, most recently
from
April 2, 2024 14:48
1d238da
to
cee86fd
Compare
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
3 times, most recently
from
April 5, 2024 12:18
be485bd
to
9fe2806
Compare
- get connect location from the nuxeo server - allow to override the connect location for the nuxeo server connected - hide the popup page building, display it when the load ends up
- allow to bind a service workspace bridge and to bootstrap an entry point with. - used in main and about popup pages
we finally get cookie header from the browser for the hosts we have permissions to. (localhost:8080, com.nuxeo.connect and nos-preprod-connect.nuxeocloud.com)
nxmatic
force-pushed
the
feature/manifest-v3-migration
branch
from
April 5, 2024 13:17
9fe2806
to
8a92af3
Compare
nxmatic
added a commit
that referenced
this pull request
Apr 6, 2024
* BDE-226 adding nix develop and direnv for development environment setup * BDE-226 initiated github CI workflow * BDE-226 reviewed building, splitted app from generated files, imported libs from node_modules * updated dependencies * splitted app from transpilled files (babel) * imported libs from dependencies * allow using local connect (let's use the URL protocol) * ... * BDE-226 v3 manifest refactor * moving from backround page to service worker * always call service worker components from popup pages * BDE-226 disabled building and running tests * BDE-226 attach zip files to the build * BDE-226 nuxeo server locator should'nt [de]activate tab while stating about nuxeo URL * BDE-226 fixing-up document browsing (json tab included) * WIP fixing up web-designed preview pipeline * BDE-226 fix CI artifact upload * BDE-226 fix typo on action operation in service connector * BDE-226 move on redirection from webRequest to declarativeNetRequest * BDE-226 log null evaluation of tab URLs * BDE-226 bind dynamically methods in constructors * BDE-226 fixing up designer live preview redirections * BDE-226 vite/terser update * BDE-226 reviewed tab activation * BDE-226 open tab when connect unauthenticated on studio project * BDE-226 inject basic auth header for redirection using https * BDE-226 accept non-redirected pages from designer-livepreview (to be refined) * BDE-226 fixing up the basic authentication rule workaround in declarative net * BDE-226 make use of session rules in declarative net engine * BDE-226 cleaning service worker bootstrap * BDE-226 removed unused information retrieves from groovy studio package name checker * BDE-226 fixing up json highlighting css loading * BDE-226 removed duplicate code from repository indexer * BDE-226 fixing up toggle classes in elastic search indexing * BDE-226 cosmit (package.json) * BDE-226 enhanced repository indexing notification * BDE-226 fixing up hot-reload operation invokes * BDE-226 bootstrap better * BDE-226 use scheme transform to redirect allowing to get the secure cookie injection * BDE-226 renamed variables in global scope for debugging * BDE-226 better handling of undo in declarative net rules * BDE-226 relocated locally all /index-* includes in popup web pages * BDE-226 introduce a base class for dynamically introspecting service worker components * BDE-226 display studio package name * BDE-226 aligned linting with code base * BDE-226 studio project registration reviewed (to be continued) * BDE-226 allow registering other developed studio project * BDE-226 fixing up buttons enabling states * BDE-226 fixing up components promise availability * BDE-226 fixing up about displaying * BDE-226 reviewed no studio project installed * BDE-226 server errors notification cleanup * BDE-226 always disable tab extension when not on an nuxeo server page (as enabling do already) * BDE-226 renamed withXXX to asXXX when not providing an input * BDE-226 fixing up missing pending rules reset in declarative net after flushing * BDE-226 better designer live review button displaying and click handling * BDE-226 fixup nuxeo operation empty content response handling - convert response into an empty JSON object in connector * BDE-226 reviewed connect and nuxeo server discovering * BDE-226 do not display registered package name in popup heading * BDE-226 fixing tab navigation on doc path * BDE-226 cleaning up manifest permissions * BDE-226 added release job in github workflow - defined version from package.json - injected built version in dotenv - generated manifest version according to * BDE-226 popups should always use promises from the service worker * BDE-226 reset jQuery handlers when reloading from step debugger * BDE-226 better promises handling when saving options * BDE-226 added development mode feature flags for 'studio-package-name' at first * BDE-226 better handling of the popup displaying - get connect location from the nuxeo server - allow to override the connect location for the nuxeo server connected - hide the popup page building, display it when the load ends up * BDE-226 shared service worker bridge bootstrap logic - allow to bind a service workspace bridge and to bootstrap an entry point with. - used in main and about popup pages * BDE-226 fixing up missing development mode when building entry points * BDE-226 trying to capture cookies from document content * BDE-226 fixing up https redirection in live preview we finally get cookie header from the browser for the hosts we have permissions to. (localhost:8080, com.nuxeo.connect and nos-preprod-connect.nuxeocloud.com) * BDE-226 ensure links content always being displayed in viewport * BDE-226 ensure we're releasing the correct zip file for chrome * BDE-226 better notifying user on hot-reload errors * BDE-226 reduced permissions on the manifest extension according to features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.