Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDE-232 do not shade the popup when not in development mode (user will get notifications later on actions) #67

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 50 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: CI Build

on:
pull_request:

Expand All @@ -17,26 +16,69 @@ on:

jobs:
build:
permissions:
contents: write # This is needed for release
actions: write # This is needed for upload-artifact

runs-on:
- ${{ github.repository_owner != github.actor && 'ubuntu-latest' || 'self-hosted' }}

steps:

- name: Checkout Commit
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup Node

- name: Cache nvm
uses: actions/cache@v4
with:
path: ~/.nvm
key: ${{ runner.os }}-nvm-${{ hashFiles('.nvmrc') }}

- name: Setup Node (github hosted runner)
if: ${{ !contains(runner.labels, 'self-hosted') }}
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'

- name: Install pnpm
node-version-file: '.nvmrc'

- name: Setup Node.js with nvm (self-hosted runner)
if: ${{ contains(runner.labels, 'self-hosted') }}
run: |
# Load NVM
[ -s "$HOME/.nvm/nvm.sh" ] || curl -s -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash
source "$HOME/.nvm/nvm.sh" # This loads nvm

# Install nodejs
nvm install
nvm use

# Add Node.js and corepack to PATH for subsequent steps
echo "$NVM_DIR/versions/node/$(nvm current)/bin" >> $GITHUB_PATH

- name: Setup pnpm
run: |
# Enable corepack
corepack enable

# Install pnpm
corepack prepare pnpm@next-8 --activate


- name: Verify installations
run: |
node --version
pnpm --version
corepack --version

- name: Cache pnpm store
uses: actions/cache@v4
with:
path: ~/.pnpm-store
key: |
${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-

- name: Install dependencies
run: pnpm install

Expand Down
1 change: 1 addition & 0 deletions src/main/manifest-chrome.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"tabs"
],
"host_permissions": [
"http://*.internal:*/*",
"http://localhost:8080/*",
"https://nos-preprod-connect.nuxeocloud.com/*",
"https://connect.nuxeo.com/*"
Expand Down
5 changes: 0 additions & 5 deletions src/popup/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -445,11 +445,6 @@ function loadPage(worker) {
developmentMode,
package: registeredPackage
} = registration;
if (!developmentMode) {
$('div.shade').show();
$('#development-mode-disabled').show();
$('#development-mode-disabled #serverUrl').text(serverLocation);
}
if (connectSubscription.errorMessage) {
const alertText = `
Cannot retrieve your server registration from \`${connectUrl}\`...
Expand Down