WEBUI-1610: Review comment: javascript:void(0) also exist on other files

nuxeo · Dec 11, 2024 · 5748bc7 · 5748bc7
1 parent 6f07133
commit 5748bc7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/storybook/src/elements/nuxeo-actions-menu/nuxeo-actions-menu.stories.js b/storybook/src/elements/nuxeo-actions-menu/nuxeo-actions-menu.stories.js
@@ -28,7 +28,7 @@ storiesOf('UI/nuxeo-actions-menu', module).add('Default', () => {
     <nuxeo-actions-menu>
       ${list.map(
         (i) => html`
-          <nuxeo-link-button href="javascript:void(0)" icon=${i} label=${i}> </nuxeo-link-button>
+          <nuxeo-link-button href="#" icon=${i} label=${i}> </nuxeo-link-button>
         `,
       )}
     </nuxeo-actions-menu>

diff --git a/ui/import-href.js b/ui/import-href.js
@@ -104,7 +104,7 @@ export const importHref = function(href, onload, onerror, optAsync) {
  */
 export const importHTML = (html) => {
   const tmpl = document.createElement('template');
-  const nuxeoNonceValue = Nuxeo.UI.config.nonce || ''
+  const nuxeoNonceValue = Nuxeo && Nuxeo.UI && Nuxeo.UI.config && Nuxeo.UI.config.nonce || ''
   tmpl.innerHTML = html;
   [...tmpl.content.children].forEach((el) => {
     if (el.tagName === 'SCRIPT' && !el.src) {

diff --git a/ui/nuxeo-aggregation/nuxeo-checkbox-aggregation.js b/ui/nuxeo-aggregation/nuxeo-checkbox-aggregation.js
@@ -187,7 +187,9 @@ import { AggregationBehavior } from './nuxeo-aggregation-behavior.js';
                     </template>
                   </dom-repeat>
                   <span hidden$="[[_hideShowMoreButton(buckets, visibleItems)]]" class="show-more-button">
-                    <a href="javascript:void(0);" on-tap="_toggleShow"> [[_computeShowMoreLabel(_showAll, i18n)]] </a>
+                    <a href="#" on-tap="_toggleShow">
+                      [[_computeShowMoreLabel(_showAll, i18n)]]
+                    </a>
                   </span>
                 </template>
               </dom-if>
@@ -280,7 +282,8 @@ import { AggregationBehavior } from './nuxeo-aggregation-behavior.js';
       return `hardware:keyboard-arrow-${opened ? 'up' : 'down'}`;
     }
 
-    _toggleShow() {
+    _toggleShow(e) {
+      e.preventDefault();
       this._set_showAll(!this._showAll);
     }