Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXPY-253: Restore capability to use the client with a local HTTP server (Sourcery refactored) #301

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Jan 18, 2024

Pull Request #300 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch, then run:

git fetch origin sourcery/wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from gitofanindya January 18, 2024 04:13
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server@3c17ecd). Click here to learn what that means.

❗ Current head 7cc6f64 differs from pull request most recent head 5c78dee. Consider uploading reports for the commit 5c78dee to get more accurate results

Additional details and impacted files
@@                                              Coverage Diff                                              @@
##             wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server     #301   +/-   ##
=============================================================================================================
  Coverage                                                                              ?   96.52%           
=============================================================================================================
  Files                                                                                 ?       29           
  Lines                                                                                 ?     1811           
  Branches                                                                              ?        0           
=============================================================================================================
  Hits                                                                                  ?     1748           
  Misses                                                                                ?       63           
  Partials                                                                              ?        0           
Flag Coverage Δ
functional 89.89% <0.00%> (?)
unit 51.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sourcery-ai sourcery-ai bot force-pushed the sourcery/wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch from e07df97 to 7cc6f64 Compare January 18, 2024 04:16
@sourcery-ai sourcery-ai bot force-pushed the sourcery/wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch from 7cc6f64 to 5c78dee Compare January 18, 2024 04:36
cookies = kwargs.pop("cookies", None)
if cookies:
if cookies := kwargs.pop("cookies", None):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function NuxeoClient.__init__ refactored with the following changes:

Comment on lines -265 to +264
enrichers = kwargs.pop("enrichers", None)
if enrichers:
if enrichers := kwargs.pop("enrichers", None):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function NuxeoClient.request refactored with the following changes:

@gitofanindya gitofanindya force-pushed the wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server branch 18 times, most recently from bbe70bb to 7e3bff1 Compare February 27, 2024 07:48
Base automatically changed from wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server to master February 27, 2024 08:06
@mr-shekhar mr-shekhar closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants