-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXPY-253: Restore capability to use the client with a local HTTP server (Sourcery refactored) #301
Conversation
Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server #301 +/- ##
=============================================================================================================
Coverage ? 96.52%
=============================================================================================================
Files ? 29
Lines ? 1811
Branches ? 0
=============================================================================================================
Hits ? 1748
Misses ? 63
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e07df97
to
7cc6f64
Compare
7cc6f64
to
5c78dee
Compare
cookies = kwargs.pop("cookies", None) | ||
if cookies: | ||
if cookies := kwargs.pop("cookies", None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function NuxeoClient.__init__
refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression
)
enrichers = kwargs.pop("enrichers", None) | ||
if enrichers: | ||
if enrichers := kwargs.pop("enrichers", None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function NuxeoClient.request
refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression
)
bbe70bb
to
7e3bff1
Compare
Pull Request #300 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
wip-NXPY-253-Restore-capability-to-use-the-client-with-a-local-HTTP-server
branch, then run:Help us improve this pull request!