Skip to content

Commit

Permalink
Revert "WEBUI-1579: Clear button in select all functionality shows cs…
Browse files Browse the repository at this point in the history
…p error"

This reverts commit 963a42e.
  • Loading branch information
alokhyland authored Sep 16, 2024
1 parent f257a62 commit 2cac23d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
5 changes: 2 additions & 3 deletions addons/nuxeo-csv/elements/nuxeo-document-import-csv.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ Polymer({
<template is="dom-if" if="[[!hasFile]]">
<div class="vertical layout center center-justified flex">
<div class="dropzone-label horizontal layout center center-justified">
<a href="#" on-tap="_showUploadDialog"> [[i18n('csv.import.clickOrDrop')]]</a>
<a href="javascript:undefined" on-tap="_showUploadDialog"> [[i18n('csv.import.clickOrDrop')]]</a>
</div>
</div>
</template>
Expand Down Expand Up @@ -581,8 +581,7 @@ Polymer({
}
},

_showUploadDialog(e) {
e.preventDefault();
_showUploadDialog() {
this.$.uploadFiles.click();
},

Expand Down
10 changes: 4 additions & 6 deletions elements/nuxeo-selection/nuxeo-selection-toolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Polymer({
<span class="count" aria-live="polite">
[[i18n('selectionToolbar.selected.items', selectedItems.length)]]
</span>
<a class="selectionLink" on-tap="toogleSelectedItemsPopup" href="#">
<a class="selectionLink" on-tap="toogleSelectedItemsPopup" href="javascript:void(0)">
<span>[[i18n('selectionToolbar.display.selection')]]</span>
</a>
</template>
Expand All @@ -121,7 +121,7 @@ Polymer({
<template is="dom-if" if="[[selectAllActive]]">
<span class="count" aria-live="polite">[[i18n('selectionToolbar.selected.all', _resultsCount)]]</span>
</template>
<a class="selectionLink" on-tap="clearSelection" href="#">
<a class="selectionLink" on-tap="clearSelection" href="javascript:void(0)">
<span>[[i18n('command.clear')]]</span>
</a>
</div>
Expand Down Expand Up @@ -188,13 +188,11 @@ Polymer({
this.hidden = !this.selectedItems || this.selectedItems.length === 0;
},

toogleSelectedItemsPopup(e) {
e.preventDefault();
toogleSelectedItemsPopup() {
this.$$('#selectedItemsPopup').toggle();
},

clearSelection(e) {
e.preventDefault();
clearSelection() {
this.fire('clear-selected-items');
},
});
5 changes: 2 additions & 3 deletions elements/workflow/nuxeo-document-task.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Polymer({
</div>
</template>
</div>
<a href="#" on-tap="_toggleGraphDialog" class="view-graph">[[i18n('tasks.viewGraph')]]</a>
<a href="javascript:undefined" on-tap="_toggleGraphDialog" class="view-graph">[[i18n('tasks.viewGraph')]]</a>
<div class="horizontal spaced">
<span>[[i18n(tasks.directive)]]</span>
</div>
Expand Down Expand Up @@ -314,8 +314,7 @@ Polymer({
.finally(() => this._setProcessing(false));
},

_toggleGraphDialog(e) {
e.preventDefault();
_toggleGraphDialog() {
this.$.graph.show();
},

Expand Down

0 comments on commit 2cac23d

Please sign in to comment.