Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WEBUI-1120: make quick search debounce requests
- Loading branch information
1 parent
f39ec9c
commit 6dff339
6dff339There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakeshkumar1019
Kind of quick win fix but only delay a little the display of results and in the end didn't fix at all the root cause of the initial issue reported in SUPNXP-34884 :
Results from "Ele" come after 5 secondes so it override the one for the complete word "Elexir" that take 2 seconds to complete. Here a 500ms debounce value won't change anything. It's about the logic not the params.
A good fix would be to define 2 new integer properties on the element :
Then update the _searchTermChanged function with something like this
`_searchTermChanged: function() {
this.$.selector.selected = 0;
const currentQuery = this.searchTerm;
const currentQueryId = ++this.lastQueryId; // increment and get a unique ID for this query
if (this.searchTerm === '') {
this.items = [];
} else {
this.debounce('suggester-search', function() {
this.$.op.execute().then(function() {
// Check if this query is later than the last completed query
if (currentQueryId >= this.lastCompletedQueryId) {
this.lastCompletedQueryId = currentQueryId; // Update the last completed query ID
// ... your existing logic to populate this.items
}
}.bind(this));
}.bind(this), this.searchDelay);
}
};`
this insure that you display results in the order of the queries made, but skip any results that return out-of-order, i.e., if a newer query has already returned results