Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBUI-1260: backward port: need to downgrade chrome browser version #1976

Conversation

rahuljain-dev
Copy link
Contributor

@rahuljain-dev rahuljain-dev commented Sep 19, 2023

https://jira.nuxeo.com/browse/WEBUI-1260

note for a11y changes:
Version[axe-core]:4.7.2
[home.js] color-contrast changed to color-contrast-enhanced due to version upgrade to 4.8.1

@rahuljain-dev rahuljain-dev requested a review from a team as a code owner September 19, 2023 10:50
@rahuljain-dev rahuljain-dev force-pushed the fix-WEBUI-1260-need-to-downgrade-chrome-browser-version-3.0.x branch 5 times, most recently from 25bc2b6 to abb0e99 Compare September 19, 2023 11:10
@rahuljain-dev rahuljain-dev force-pushed the fix-WEBUI-1260-need-to-downgrade-chrome-browser-version-3.0.x branch from abb0e99 to e3101eb Compare September 19, 2023 11:22
Copy link
Collaborator

@rakeshkumar1019 rakeshkumar1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍.

Copy link
Contributor

@poonamyadav252 poonamyadav252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but only violation point needs to be discussed with the PO.

Copy link

@arupmmi07 arupmmi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@rahuljain-dev rahuljain-dev merged commit 657147b into maintenance-3.0.x Sep 20, 2023
9 checks passed
@rahuljain-dev rahuljain-dev deleted the fix-WEBUI-1260-need-to-downgrade-chrome-browser-version-3.0.x branch September 20, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants