fix: do not select ins element inserted by Google and raising a adsbygoogle.push() error #192
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Adsense script automatically insert an invisible ins element at the bottom of the page
So if we don't put any ads component on a page, the current onload script will find this ins (with className 'adsbygoogle') and try to call adsbygoogle.push with raises the error "All ins elements in the DOM with class=adsbygoogle already have ads in them."
I think this pull request fixes #156 and maybe #179
Also it works only when onPageLoad option is set to true.