Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Nuxt 3 #214

Merged
merged 22 commits into from
Oct 6, 2023
Merged

feat: Support Nuxt 3 #214

merged 22 commits into from
Oct 6, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Sep 15, 2023

#213

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Support Nuxt 3 with reference to https://github.com/wattanx/style-resources-module.
(If you would prefer to make the PR a little smaller in size, please let me know.)

I think Same Repositories, same package name is better.

@wattanx wattanx marked this pull request as ready for review September 17, 2023 07:47
@TheAlexLichter
Copy link
Collaborator

In this case, same package + same repository is more than fine πŸ‘

Copy link
Collaborator

@TheAlexLichter TheAlexLichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides a few nits πŸ‘

README.md Outdated

[![npm version][npm-version-src]][npm-version-href]
[![npm downloads][npm-downloads-src]][npm-downloads-href]
[![Codecov][codecov-src]][codecov-href]
[![License][license-src]][license-href]

>
If you would like to use the stable version for Nuxt 2, please see the [`mater` branch](https://github.com/nuxt-community/style-resources-module/tree/master)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you would like to use the stable version for Nuxt 2, please see the [`mater` branch](https://github.com/nuxt-community/style-resources-module/tree/master)
If you would like to use the stable version for Nuxt 2, please see the [`master` branch](https://github.com/nuxt-community/style-resources-module/tree/master)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we might want to say "use major version XYZ" here? πŸ€”

Copy link
Collaborator Author

@wattanx wattanx Sep 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review ❀️
Added description to use nuxtjs/style-resources@^1.
Is it OK to create a v1 branch?
(If OK, I would like you to make it as I do not have the authorization to do so πŸ™ .)

ae115a1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -8,7 +8,15 @@
"name": "Alexander Lichter <[email protected]>"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself here too! πŸ‘

@harlan-zw
Copy link
Contributor

Not sure what this Travis CI integration is doing. Going to merge as it seems good to go, can make any fixes outside of this PR.

@harlan-zw harlan-zw merged commit 1dd88cb into nuxt-modules:master Oct 6, 2023
@wattanx wattanx mentioned this pull request Oct 6, 2023
@TheAlexLichter
Copy link
Collaborator

@danielroe could you remove travis from the org? I sadly don't have access to it πŸ™ˆ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants