-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Nuxt 3 #214
feat: Support Nuxt 3 #214
Conversation
In this case, same package + same repository is more than fine π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides a few nits π
README.md
Outdated
|
||
[![npm version][npm-version-src]][npm-version-href] | ||
[![npm downloads][npm-downloads-src]][npm-downloads-href] | ||
[![Codecov][codecov-src]][codecov-href] | ||
[![License][license-src]][license-href] | ||
|
||
> | ||
If you would like to use the stable version for Nuxt 2, please see the [`mater` branch](https://github.com/nuxt-community/style-resources-module/tree/master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would like to use the stable version for Nuxt 2, please see the [`mater` branch](https://github.com/nuxt-community/style-resources-module/tree/master) | |
If you would like to use the stable version for Nuxt 2, please see the [`master` branch](https://github.com/nuxt-community/style-resources-module/tree/master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we might want to say "use major version XYZ" here? π€
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review β€οΈ
Added description to use nuxtjs/style-resources@^1
.
Is it OK to create a v1
branch?
(If OK, I would like you to make it as I do not have the authorization to do so π .)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created v1
branch.
https://github.com/nuxt-community/style-resources-module/tree/v1
@@ -8,7 +8,15 @@ | |||
"name": "Alexander Lichter <[email protected]>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add yourself here too! π
Co-authored-by: Alexander Lichter <[email protected]>
Not sure what this Travis CI integration is doing. Going to merge as it seems good to go, can make any fixes outside of this PR. |
@danielroe could you remove travis from the org? I sadly don't have access to it π |
#213
β Type of change
π Description
Support Nuxt 3 with reference to https://github.com/wattanx/style-resources-module.
(If you would prefer to make the PR a little smaller in size, please let me know.)
I think
Same Repositories, same package name
is better.