Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to liblouis 3.32 #17469

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update to liblouis 3.32 #17469

merged 1 commit into from
Dec 4, 2024

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Dec 2, 2024

Link to issue number:

None

Summary of the issue:

Update to liblouis 3.32

Description of user facing changes

None

Description of development approach

  1. Update submodule
  2. In this version, a dependency on Gnulib was introduced that doesn't build on Windows. See NMAKE on Windows is broken liblouis/liblouis#1689 . I fixed this using the approach from Use _strnicmp on windows liblouis/liblouis#1686. In short, rather than posix strncasecmp, we use _strnicmp .

Testing strategy:

Unit tests, running from source

Known issues with pull request:

Based on the second point as noted below development approach, an alternative could be just removing the metadata part from our liblouis build, which can be used by simply commenting out 'metadata.c' from sconscript.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@AppVeyorBot
Copy link

See test results for failed build of commit f1063b994c

@AppVeyorBot
Copy link

See test results for failed build of commit 94668c8cc4

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 2, 2024
@LeonarddeR LeonarddeR marked this pull request as ready for review December 3, 2024 11:40
@LeonarddeR LeonarddeR requested a review from a team as a code owner December 3, 2024 11:40
@LeonarddeR LeonarddeR requested a review from seanbudd December 3, 2024 11:40
@seanbudd seanbudd merged commit d45008f into nvaccess:master Dec 4, 2024
5 checks passed
@seanbudd
Copy link
Member

seanbudd commented Dec 4, 2024

Thanks @LeonarddeR

@github-actions github-actions bot added this to the 2025.1 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants