Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow associating ComboBoxes to labels #17476

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Allow associating ComboBoxes to labels #17476

merged 5 commits into from
Dec 11, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Dec 3, 2024

Link to issue number:

None

Summary of the issue:

We need to add support for associating labels to a wx.ComboBox using gui.guiHelper.associateElements.

Additionally, the association for wx.StaticText and wx.CheckBox was undocumented in the functions docstring.

Description of user facing changes

Description of development approach

Added TypeVars and rewrote type hinting to be more specific, clear and self-documenting.

Added support to ComboBoxes for horizontal controls.

Testing strategy:

Tested with NVDA remote

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd requested a review from a team as a code owner December 3, 2024 05:16
@seanbudd seanbudd requested a review from SaschaCowley December 3, 2024 05:16
source/gui/guiHelper.py Outdated Show resolved Hide resolved
source/gui/guiHelper.py Outdated Show resolved Hide resolved
source/gui/guiHelper.py Show resolved Hide resolved
source/gui/guiHelper.py Show resolved Hide resolved
source/gui/guiHelper.py Outdated Show resolved Hide resolved
source/gui/guiHelper.py Outdated Show resolved Hide resolved
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 9, 2024
Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should an entry be added to changes for developers?

source/gui/guiHelper.py Outdated Show resolved Hide resolved
source/gui/guiHelper.py Outdated Show resolved Hide resolved
source/gui/guiHelper.py Outdated Show resolved Hide resolved
@SaschaCowley
Copy link
Member

@seanbudd can you add a note to the changelog please? I feel like this is a useful addition for devs to know about

@seanbudd
Copy link
Member Author

@SaschaCowley - done

Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanbudd

@SaschaCowley SaschaCowley merged commit cef4abb into master Dec 11, 2024
5 checks passed
@SaschaCowley SaschaCowley deleted the associateComboBox branch December 11, 2024 01:52
@github-actions github-actions bot added this to the 2025.1 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants