-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow associating ComboBoxes to labels #17476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an entry be added to changes for developers?
Co-authored-by: Sascha Cowley <[email protected]>
@seanbudd can you add a note to the changelog please? I feel like this is a useful addition for devs to know about |
@SaschaCowley - done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seanbudd
Link to issue number:
None
Summary of the issue:
We need to add support for associating labels to a wx.ComboBox using
gui.guiHelper.associateElements
.Additionally, the association for
wx.StaticText
andwx.CheckBox
was undocumented in the functions docstring.Description of user facing changes
Description of development approach
Added TypeVars and rewrote type hinting to be more specific, clear and self-documenting.
Added support to ComboBoxes for horizontal controls.
Testing strategy:
Tested with NVDA remote
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary