Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tighten logging and print an informational header #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tbg
Copy link
Collaborator

@tbg tbg commented Dec 19, 2024

This PR tightens up logging. In particular, it makes sure the spinner lines are completely gone when completed. Also, we print (to stdout) a header summarizing the old and new sha as well as the benchdiff invocation. The idea is that these are always useful to include with the results.

Example output:

$ benchdiff -c 1 -d 1x .
old:  a57c216 Merge pull request #34 from tbg/col-prof
new:  0df532a Merge pull request #36 from tbg/main
args: benchdiff "-c" "1" "-d" "1x" "."

name                                                        old time/op    new time/op    delta
RPC/payloadSize=______1/framework=grpc/mode=Unary-10           848µs ± 0%     935µs ± 0%   ~     (p=1.000 n=1+1)
RPC/payloadSize=______1/framework=grpc/mode=Stream-10          217µs ± 0%     156µs ± 0%   ~     (p=1.000 n=1+1)
[...]

demo

tbg added 6 commits December 19, 2024 06:43
Inconsequential since benchdiff is likely rarely used with multiple packages,
but still, now it's correct.
We'll log this in a better location in a follow-up commit.
@tbg tbg requested a review from nvanbenschoten December 19, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants