build: improve rockspec #391
Conversation
|
Looks ok to me. What would be perfect would be to upload a new version on luarocks.org |
the data folder was not copied. Also the 'builtin' type will copy automatically everyhting that is in the lua folder
|
FWIW with Nix this branch fixes telescope's failure to syntax highlight. +1 for merging. Example usage |
|
Thanks :) |
|
do i need to do something to publish a newer version? uploade says teto here: https://luarocks.org/modules/teto/plenary.nvim |
|
@Conni2461 I've removed my package from luarocks.org so now plenary.nvim developers are in charge ! EDIT: what would be cool is to add the "neovim" label to the package (from the luarocks.org interface). It should be picked up from the rockspec but in my experience, that was not the case. EDIT2: another example how some lua developers version their rockspecs: https://github.com/starwing/lua-protobuf/tree/master/rockspecs |
|
@Conni2461 sorry to poke you again, there are a few rockspecs I wanna install that lists plenary as a dependency but now that I removed it from luarocks I an't install those anymore. Do you think you could upload the plenary rockspec to the root manifest on luarocks.org or should I reupload it myself until you or another maintainer get time ? |
|
I'll upload one tomorrow. Sorry i am currently really busy and it slipped my mind. Thanks for poking again :) |
|
okay its uploaded: https://luarocks.org/modules/Conni2461/plenary.nvim but i can't seem to get luarocks to read any of my organizations so that nvim-lua is the owner of the rockspec. Do you know if that is possible? i found a open resty "org" https://luarocks.org/modules/openresty but i am not sure if this is even a real github org that was used or if they just created a openresty luarocks account. |
|
I dont think a team can own a rockspec. Probably for the same reasons you can't generate a github API token for a github org. There may be a limitation on the luarocks side that prevents several accounts to own a rockspec, one would need to doublecheck (on their gitter maybe). In my settings I can link different github accounts to my profile so probably one can create a shared account on luarocks and link different org members github account into it. I will ask for more information. |
|
Indeed it's not possible (yet): |
the data folder was not copied. Also the 'builtin' type will copy automatically everyhting that is in the lua folder