Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filesystem): open in right below or left above split #1294

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

Blackmorse
Copy link
Contributor

This pull request addresses a common scenario where I often open files in a split, but I want control over whether the split appears on the left or right relative to the last buffer. With this update, I've introduced the option to open files using rightabove or leftbelow vs. This enhancement provides more control over split placement, offering flexibility based on user preference. I believe this feature could be beneficial for users who seek a more tailored split behavior.

@cseickel
Copy link
Contributor

cseickel commented Jan 7, 2024

Since we have a vsplit, it make sense to have these other variations as well. For completeness, you should also have version of the new command available in the git_status and buffers sources.

There should also be documentation of the new commands in :h neo-tree-navigation.

@Blackmorse
Copy link
Contributor Author

@cseickel , thanks for you review

I've added documentation for the new command.

Regarding to support for git_status and buffers sources, I believe that new commands are already available for them, since they should be added by the call of _add_common_commands at <source>/commands.lua (the same as for split and vsplit)

@cseickel
Copy link
Contributor

cseickel commented Jan 7, 2024

Regarding to support for git_status and buffers sources, I believe that new commands are already available for them, since they should be added by the call of _add_common_commands at <source>/commands.lua (the same as for split and vsplit)

You're absolutely correct, sorry about that.

@cseickel cseickel merged commit 2f2d088 into nvim-neo-tree:main Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants