fix(document_symbols): handle SymbolInformation responses #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pynappo
force-pushed
the
1085-fix-docsymbols-range
branch
from
2671f76 to
9f83535
Compare
|
pinging @cseickel for approval (also, for future reference, should i only be pinging if i want one of my PRs merged, or does requesting a review also work?) |
|
I don't see the review request unless you ping me. I just gave you permission to merge without a review. Feel free to do so unless you really want me to offer feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1085.
motivation
LSP states that a document symbol request can return SymbolInformation objects or DocumentSymbol.
notes
Haven't tested with the servers that use said older implementations yet, but just based on the types it should work?
edit: tested with bash_ls, seems to work fine