Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: neorocksTest Nix helper #50

Merged
merged 9 commits into from
Aug 27, 2023
Merged

feat: neorocksTest Nix helper #50

merged 9 commits into from
Aug 27, 2023

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Aug 25, 2023

No description provided.

@mrcjkb mrcjkb self-assigned this Aug 25, 2023
@mrcjkb mrcjkb marked this pull request as draft August 25, 2023 16:27
@mrcjkb mrcjkb requested a review from teto August 25, 2023 16:27
@mrcjkb mrcjkb linked an issue Aug 25, 2023 that may be closed by this pull request
@mrcjkb mrcjkb force-pushed the nix-check-support branch 3 times, most recently from 2e39866 to 2fd2e95 Compare August 26, 2023 14:19
@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 26, 2023

For some reason it' doesn't seem to be picking up the lua_interpreter = "neolua" config - although this works just fine in the integration test that uses nix profile install...

@mrcjkb mrcjkb force-pushed the nix-check-support branch from 2fd2e95 to da6189e Compare August 26, 2023 14:37
@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 26, 2023

🤔 when I copy the generated $LUAROCKS_CONFIG, I can reproduce the behaviour in which it does not use the neolua interpreter locally.
If I comment out the rocks_trees (causing luarocks to download the dependencies), it uses neolua correctly.

@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 26, 2023

The issue seems to be that .busted_wrapped has a call to luajit hardcoded, and luarocks can't change that. Normally, it would change it to use the lua_interpreter.

@mrcjkb mrcjkb force-pushed the nix-check-support branch from da6189e to 0af6224 Compare August 26, 2023 17:54
@mrcjkb mrcjkb marked this pull request as ready for review August 26, 2023 17:55
@mrcjkb mrcjkb enabled auto-merge (squash) August 27, 2023 00:36
@mrcjkb mrcjkb merged commit 4f36ba7 into master Aug 27, 2023
nix/overlay.nix Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for nix checks
1 participant