Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn about wrong 'dir' values #35

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

teto
Copy link
Member

@teto teto commented Aug 19, 2024

Warn about non-existing directories to help the user debug its config.

Feel free to edit/do anything to this PR

teto added 2 commits August 19, 2024 10:33
Warn about non-existing directories to help the user debug its config
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@teto teto force-pushed the teto/warn-about-wrong-directory branch from cbab7e7 to d48aceb Compare August 19, 2024 09:06
lua/rocks-dev/init.lua Outdated Show resolved Hide resolved
Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
At a later time, we could change the warning to Run ':checkhealth rocks-dev.nvim' and add health checks (like we do in rocks-config).

This will still try to load the plugin if the directory is not found. Do we want to skip that?

@teto
Copy link
Member Author

teto commented Aug 19, 2024

This will still try to load the plugin if the directory is not found. Do we want to skip that?

I think it's fine. If user wants to restore the folder after neovim's start, it might work again without having to restart neovim.
I agree with the checkhealth, would be nice to have but this addresses the most urgent part.

@mrcjkb mrcjkb merged commit 84bbfbf into main Aug 19, 2024
5 checks passed
@mrcjkb mrcjkb deleted the teto/warn-about-wrong-directory branch August 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants