perf: use cache for outdated rocks and trigger on more events #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
commented
Aug 6, 2024
lua/rocks-edit/sources/updates.lua
Outdated
Comment on lines
3
to
13
| local cache_populated = false | ||
|
|
||
| require("rocks-edit.api").register(function(toml, diagnostic) | ||
| nio.run(function() | ||
| local updates = require("rocks.state").outdated_rocks() | ||
| local updates = require("rocks.api").try_get_cached_outdated_rocks() | ||
| --- HACK: internal API! Rocks.nvim should provide an option to fall back to a | ||
| --- luarocks query if the cache is not populated. | ||
| if not cache_populated and #updates == 0 then | ||
| updates = require("rocks.state").outdated_rocks() | ||
| cache_populated = true | ||
| end |
There was a problem hiding this comment.
This is hacky and should be replaced with a rocks.nvim API (see commend).
Also, we need a user event that triggers a refresh when the cache has been updated.
This was referenced Aug 6, 2024
Closed
mrcjkb
force-pushed
the
use-cache
branch
2 times, most recently
from
a9eca46 to
8200e6e
Compare
|
I've ended up adding a bit more to this than initially planned:
|
|
@vhyrro this one is ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.