Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for an optional import config path #41

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

simifalaye
Copy link
Contributor

Dependent on this PR: nvim-neorocks/rocks.nvim#577

This PR adds support for specifying a config import path to automatically install treesitter rocks into instead of the base config file.

mrcjkb
mrcjkb previously approved these changes Nov 15, 2024
Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase with conflict resolution.

Otherwise, LGTM 🙏

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like stylua is failing

@simifalaye
Copy link
Contributor Author

Yeah, plus I resolved within the UI so it did a merge, hence the commit history is probably not what you want. I may need to redo this branch

@mrcjkb
Copy link
Member

mrcjkb commented Nov 15, 2024

I can squash the commits when merging 😄

@simifalaye
Copy link
Contributor Author

The commit history should be fixed now and stylua seems to pass but I'm not exactly sure what the issue with the checks is (seems to be some linking error?). The push to luarocks will be blocked until the other change to rocks.nvim is merged but that's fine

@mrcjkb
Copy link
Member

mrcjkb commented Nov 15, 2024

Ah, it's the vimdoc generation.
I forget, do you have Nix installed? If so, you can run the pre-commit hooks from the devShell.

@mrcjkb mrcjkb enabled auto-merge (squash) November 16, 2024 12:40
@mrcjkb mrcjkb disabled auto-merge November 16, 2024 12:41
@mrcjkb mrcjkb merged commit deba3c2 into nvim-neorocks:main Nov 16, 2024
2 of 3 checks passed
@mrcjkb mrcjkb mentioned this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants