Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add nix dev + build environment + ci builds #1

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Jan 17, 2024

The obligatory flakeification 😄

@mrcjkb mrcjkb requested review from teto and vhyrro January 17, 2024 18:26
@mrcjkb mrcjkb force-pushed the flake branch 3 times, most recently from 2c542ef to f59ba16 Compare January 17, 2024 18:55
flake.nix Outdated Show resolved Hide resolved
@mrcjkb
Copy link
Member Author

mrcjkb commented Jan 17, 2024

@teto for some reason, the extra buildInputs I add to the devShell (rust-analyzer, rustfmt, ...) aren't available on the PATH.
Any idea what could be the issue?

@teto
Copy link
Member

teto commented Jan 17, 2024

I am never too sure about the rules but because it's not a mkShell but the program buildInputs, in which case you need propagatedBuildInputs to propagate to PATH .
Maybe if you append .inputDerivation at the end ?

@mrcjkb
Copy link
Member Author

mrcjkb commented Jan 18, 2024

I am never too sure about the rules but because it's not a mkShell but the program buildInputs, in which case you need propagatedBuildInputs to propagate to PATH . Maybe if you append .inputDerivation at the end ?

🤔 none of it worked. Maybe it's something that rustPlatform.buildRustPackage does...
I ended up using mkShell and appending rocks.buildInputs ++ rocks.nativeBuildInputs to the shell's buildInputs.
A bit hacky, but it works 🤷

@mrcjkb mrcjkb force-pushed the flake branch 2 times, most recently from 6bc6ec1 to 4c776e8 Compare January 18, 2024 07:53
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had similar issues in the past so I get it. Approved

@mrcjkb mrcjkb merged commit a3c00da into master Jan 18, 2024
3 checks passed
@mrcjkb mrcjkb deleted the flake branch January 18, 2024 15:40
@mrcjkb
Copy link
Member Author

mrcjkb commented Jan 18, 2024

Oops... forgot to set it to squash...

@teto
Copy link
Member

teto commented Jan 18, 2024

considering the wide usage of this program, feel free to force push if you have git OCD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants