feat: rocks check
#289
Merged
feat: rocks check
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will fix the failing build in a bit. |
mrcjkb
reviewed
Dec 29, 2024
vhyrro
force-pushed
the
push-mlmvtkovvnmy
branch
from
07e1fa9 to
e6b51e6
Compare
mrcjkb
approved these changes
Dec 29, 2024
Comment on lines
+28
to
+36
| vec![ | ||
| project.root().to_string_lossy().into(), | ||
| "--exclude-files".into(), | ||
| project | ||
| .tree(LuaVersion::from(&config)?)? | ||
| .root() | ||
| .to_string_lossy() | ||
| .to_string(), | ||
| ], |
There was a problem hiding this comment.
suggestion:
Suggested change
| vec![ | |
| project.root().to_string_lossy().into(), | |
| "--exclude-files".into(), | |
| project | |
| .tree(LuaVersion::from(&config)?)? | |
| .root() | |
| .to_string_lossy() | |
| .to_string(), | |
| ], | |
| vec![ | |
| format!("{}", project.root().display()), | |
| "--exclude-files".into(), | |
| format!("{}", project | |
| .tree(LuaVersion::from(&config)?)? | |
| .root() | |
| .display()), | |
| ], |
There was a problem hiding this comment.
Not sure if that's actually better, but apparently display() is safer.
There was a problem hiding this comment.
display() does essentially the same thing as to_string_lossy by replacing all invalid unicode chars with the replacement character. Amounts to the same code in the end :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple implementation of
rocks check, which ensuresluacheckis installed and runs it for the whole source directory of a given project.Similarly to
rocks fmt, we'll want to expand this to take in a path as an argument for finer control.I don't believe we should let the user control
luacheckwith flags, that should be up to the luacheckrc file.