Remove ansi sequence from luassert output #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Details When running in a TTY luassert defaults to adding ansi colors when showning table differences for a failed test: https://github.com/nvim-lua/plenary.nvim/blob/master/lua/luassert/formatters/init.lua#L255 When looking at these through the `neotest` panel everything looks great. However diagnostics do not appear to have any ansi parsing and instead print out the raw sequence. The parameter that defines the color can be modified and effectively disabled by setting it to "none".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When running in a TTY luassert defaults to adding ansi colors when showning table differences for a failed test:
https://github.com/nvim-lua/plenary.nvim/blob/master/lua/luassert/formatters/init.lua#L255
When looking at these through the
neotestpanel everything looks great. However diagnostics do not appear to have any ansi parsing and instead print out the raw sequence.The parameter that defines the color can be modified and effectively disabled by setting it to "none".
This isn't a big deal and I can set it up per project. Also if I'm missing another way of handling this definitely LMK. As is this disables colors for both diagnostics as well as in the
neotestpanel.