Skip to content

Commit

Permalink
[actions] adjust shellcheck/windows tests to9 have a final "done" job
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Apr 16, 2021
1 parent f258227 commit 07253ec
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 5 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/shellcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: 'Tests: shellcheck'
on: [pull_request, push]

jobs:
shellcheck:
shellcheck_matrix:
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -29,3 +29,9 @@ jobs:
- run: "shellcheck --version"
- name: Run shellcheck on ${{ matrix.file }}
run: shellcheck -s ${{ matrix.shell }} ${{ matrix.file }}

shellcheck:
needs: [shellcheck_matrix]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'
17 changes: 13 additions & 4 deletions .github/workflows/windows-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ env:
NVM_INSTALL_VERSION: ${{ github.sha }}

jobs:
node_fail_install:
msys_fail_install:
# Default installation does not work due to npm_config_prefix set to C:\npm\prefix
name: 'MSYS fail prefix nvm install'
runs-on: windows-latest
Expand All @@ -18,7 +18,8 @@ jobs:
curl -fsSLo- "https://raw.githubusercontent.com/${NVM_INSTALL_GITHUB_REPO}/${NVM_INSTALL_VERSION}/install.sh" | METHOD=script bash
. "$HOME/.nvm/nvm.sh"
! nvm install --lts
nodes:
msys_matrix:
name: 'MSYS nvm install'
runs-on: windows-latest
strategy:
Expand All @@ -39,7 +40,8 @@ jobs:
fi
. "$HOME/.nvm/nvm.sh"
nvm install ${{ matrix.npm-node-version }}
node_cygwin:
cygwin_matrix:
name: 'Cygwin nvm install'
runs-on: windows-latest
steps:
Expand Down Expand Up @@ -75,7 +77,8 @@ jobs:
run: |
cd %USERPROFILE%\cygwin\bin
bash.exe "%USERPROFILE%\setup.sh"
wsl_nodes:
wsl_matrix:
name: 'WSL nvm install'
runs-on: windows-latest
env:
Expand Down Expand Up @@ -104,3 +107,9 @@ jobs:
fi
. "$HOME/.nvm/nvm.sh"
nvm install ${{ matrix.npm-node-version }}
nvm_windows:
needs: [wsl_matrix, cygwin_matrix, msys_matrix, msys_fail_install]
runs-on: ubuntu-latest
steps:
- run: 'echo tests completed'

0 comments on commit 07253ec

Please sign in to comment.