[Fix] install.sh: fix failing install tests from #3458
#3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
ljharb
added
bugs
ljharb
approved these changes
Nov 12, 2024
ljharb
changed the title
install.sh: fix failing install tests from #3458
|
Thank you for letting me fix the problem that I introduced! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw that you merged it and your message, it seems that the urchin tests aren't run until a commit is pushed - which is why we didn't catch the test failing. (So I added that as a separate PR #3466 - under the assumption that if you merge that first, we can run the test on this PR to ensure it fixes the issue)
This should address the failing tests. I missed the line for an unset $SHELL variable in
install.sh- the rest of the PR is unsetting$ZDOTDIRfor the other shells test (they will fail if it remains set). Local testing verifies this passes the urchin tests, though.