-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCSD_T2_7 GPU support #1029
Closed
jeffhammond
wants to merge
113
commits into
nwchemgit:master
from
jeffhammond:ccsd_t2_dgemm_cublas_7
Closed
CCSD_T2_7 GPU support #1029
jeffhammond
wants to merge
113
commits into
nwchemgit:master
from
jeffhammond:ccsd_t2_dgemm_cublas_7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd/nwchem into ccsd_t2_dgemm_cublas_7
this is an O(N^5) term, so it probably doesn't matter... Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
sync on oldphase was wrong. sync on the phase associated with the buffers about to be overwritten. remove oldphase variable since no longer needed. fuse the two accumulates at the end since accumulate is more expensive than memcpy. Signed-off-by: Jeff Hammond <[email protected]>
This includes a fix to the T2_8 GPU code as well. |
@jeffhammond Could you please rebase and squash commit when you are ready to go? |
I tried to rebase earlier. It was impossible. I'll have to rip it apart and create the PR from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the T2_7 terms on GPU. TCE_SORT uses
DO CONCURRENT
and is strictly GPU agnostic at a source level, but compiles to GPU code with the NVIDIA Fortran compiler. The DGEMM stuff uses the automatic CUBLAS offload and compiles for CPU as well.This would benefit from asynchrony but I'll that later. Similarly, this will benefit ICSD/NTS as well, but that's a future PR.
Performance, again on AMD 7950X and RTX 4090, for 4(H2O) with cc-pVQZ, with 16 MPI processes (ARMCI-MPI):
CPU
For (H2O)6 with cc-pVTZ, the T2_7 is closer to 2x (28 seconds vs 53 seconds).