Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert portal back to nwHacks 2024 #535

Merged
merged 26 commits into from
Nov 30, 2023
Merged

Convert portal back to nwHacks 2024 #535

merged 26 commits into from
Nov 30, 2023

Conversation

meleongg
Copy link
Member

@meleongg meleongg commented Nov 29, 2023

Description

  • reskinned portal back to nwHacks
  • nwHacks apps are open again
  • note that you'll need to set your firebase Applicant status back to "applied" or "inProgress" and set both the nested fields to false
  • also includes changes to nwHacks question ordering as mentioned here

Other considerations

@meleongg meleongg requested a review from DonaldKLee November 29, 2023 07:35
Copy link

github-actions bot commented Nov 29, 2023

Visit the preview URL for this PR (updated for commit da72b13):

https://nwplus-ubc--pr535-convert-to-nwhacks-5519xbqt.web.app

(expires Thu, 07 Dec 2023 07:23:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@meleongg meleongg requested a review from naijwu November 29, 2023 07:38
Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Nitpicks:

  • after submitting your application, the complete registration button is still visible and can be hovered (gives user impression that they can click on it)
    image

  • there is suppose to be a coloured dot near "live", but the dot is the same colour as the background
    image

  • are we still including the draw a picture question that Lincoln made?

  • colours aren't accurate on the hacker side (schedule page, faq, etc), I assume there'll be a new reskin in Dec and that this one is only for application?

@meleongg
Copy link
Member Author

  • the Complete Your Registration button is greyed out so clickers can't click on it
  • fixed live dot
  • I don't think it's fully finished LOL

@meleongg meleongg merged commit ac6d3de into dev Nov 30, 2023
2 checks passed
@meleongg meleongg deleted the convert-to-nwhacks branch November 30, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants