Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attended Events component #627

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Attended Events component #627

merged 6 commits into from
Oct 31, 2024

Conversation

daniel-panhead
Copy link
Contributor

Description

image

slay bro

Added attended events component! Events with no type are just gray, otherwise they correspond to the legend.

Other considerations

Also added some basic scaffolding for the events page, feel free to use or discard for laying out other components.

Overflow of the components was added but currently doesn't work since the parent container doesn't have a max height. Once other components are added we can figure out a reasonable max height for the component ^^

Copy link

github-actions bot commented Oct 24, 2024

Visit the preview URL for this PR (updated for commit 0d266e8):

https://nwplus-ubc--pr627-daniel-attended-even-gd8qmoww.web.app

(expires Thu, 07 Nov 2024 01:37:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@ErpingS ErpingS self-requested a review October 31, 2024 01:30
Copy link
Contributor

@ErpingS ErpingS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-panhead daniel-panhead merged commit e6e5cdc into dev Oct 31, 2024
2 checks passed
@daniel-panhead daniel-panhead deleted the daniel/attended-events branch October 31, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants