Dev -> Main #634
Dev -> Main #634
Conversation
Rewards component UI
|
Visit the preview URL for this PR (updated for commit 27c8285): https://nwplus-ubc--pr634-dev-dt11h1eo.web.app (expires Fri, 08 Nov 2024 18:03:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48 |
| color: ${p => p.theme.colors.bar}; | ||
| text-align: right; | ||
| margin-top: 8px; | ||
| ` |
There was a problem hiding this comment.
should these colours be theme.colors.text?
There was a problem hiding this comment.
oh idk why it didn't highlight correctly, but i was talking about all the text colours
There was a problem hiding this comment.
it should be the same color as the bar! it's for the points here above the bar 
There was a problem hiding this comment.
ohhh okay yeah that sounds good! should the the other ones should be colors.text instead of colors.lines?
| height: 24px; | ||
| border: 2px solid ${p => p.theme.colors.lines}; | ||
| border-radius: 50%; | ||
| color: ${p => p.theme.colors.lines}; |
There was a problem hiding this comment.
oh it looks like theme.colors.lines and theme.colors.text both have the same hexcode of #45171A, should I just change it to text so it's more consistent or is it fine to leave it?
There was a problem hiding this comment.
yeah i see why that was confusing LOL
it would be amazing if you could change it to text so it matches up with the variable being used in figma! in case those two variables are different for future reskins
There was a problem hiding this comment.
i'll write the docs for this sometime it's my bad for not specifying it sorry
There was a problem hiding this comment.
ok sounds good! if i push another change do you know if i have to open a new PR because this one was merged?
There was a problem hiding this comment.
yepp i can help merge it in
| height: 20px; | ||
|
|
||
| &::-webkit-progress-bar { | ||
| background-color: ${p => p.theme.colors.barBackground}; |
There was a problem hiding this comment.
i think design forgot to add variables for these barBackground and bar, please let them know to add it so everything's synced up
No description provided.