fix(bld): await archiver.finalize (#1333)

Fixes: #1328
nwutils · Jan 1, 2025 · 580668f · 580668f
1 parent 8c09908
commit 580668f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -16,7 +16,7 @@ jobs:
         os:
         - macos-15
         - ubuntu-24.04
-        - windows-2022
+        - windows-2025
       fail-fast: false
     runs-on: ${{ matrix.os }}
     permissions:

diff --git a/SECURITY.md b/SECURITY.md
@@ -0,0 +1,5 @@
+# Reporting a Vulnerability
+
+If you discover a security vulnerability within `nw-builder`, please submit a report via the Github's Private Vulnerability Reporting feature.
+
+All security vulnerabilities will be promptly addressed.
diff --git a/src/bld.js b/src/bld.js
@@ -374,7 +374,7 @@ const compress = async ({
     const writeStream = fs.createWriteStream(`${outDir}.zip`);
     archive.pipe(writeStream);
     archive.directory(outDir, false);
-    archive.finalize();
+    await archive.finalize();
   } else if (zip === 'tar') {
     await tar.create({
       gzip: false,