fix: format

nwutils · Oct 5, 2023 · e9fda7f · e9fda7f
1 parent cd585dc
commit e9fda7f
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 43 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -12,8 +12,8 @@ jobs:
   e2e:
     strategy:
       matrix:
-        os: [macos-13]
-        node: [20]
+        os: [macos-12, ubuntu-22.04, windows-2022]
+        node: [16, 18, 20]
       fail-fast: false
     runs-on: ${{ matrix.os }}
     steps:
@@ -32,17 +32,13 @@ jobs:
         run: corepack enable
       - name: Install dependencies
         run: npm ci
-      - name: TMP - Build Preview
-        run: npm run demo
-      - name: TMP - Run Preview
-        run: npm run preview
-      # - name: Check for formatting errors
-      #   run: npm run ci:fmt
-      # - name: Check for linting errors
-      #   run: npm run ci:lnt
-      # - name: Link module
-      #   run: npm link nw-builder
-      # - name: Run unit tests
-      #   run: npm run test:unit
-      # - name: Run Selenium tests
-      #   run: npm run test:e2e
+      - name: Check for formatting errors
+        run: npm run ci:fmt
+      - name: Check for linting errors
+        run: npm run ci:lnt
+      - name: Link module
+        run: npm link nw-builder
+      - name: Run unit tests
+        run: npm run test:unit
+      - name: Run Selenium tests
+        run: npm run test:e2e
diff --git a/src/get.js b/src/get.js
@@ -197,22 +197,22 @@ async function get_nwjs({
             bar.stop();
             if (platform === "linux") {
               compressing.tgz.uncompress(out, cacheDir).then(() => resolve());
-            // } else if (platform === "osx") {
-            //   //TODO: compressing package does not restore symlinks on some macOS (eg: circleCI)
-            //   const exec = function (cmd) {
-            //     log.debug(cmd);
-            //     const result = spawnSync(cmd, {
-            //       shell: true,
-            //       stdio: "inherit",
-            //     });
-            //     if (result.status !== 0) {
-            //       log.debug(`Command failed with status ${result.status}`);
-            //       if (result.error) console.log(result.error);
-            //       EXIT(1);
-            //     }
-            //     return resolve();
-            //   };
-            //   exec(`unzip -o "${out}" -d "${cacheDir}"`);
+              // } else if (platform === "osx") {
+              //   //TODO: compressing package does not restore symlinks on some macOS (eg: circleCI)
+              //   const exec = function (cmd) {
+              //     log.debug(cmd);
+              //     const result = spawnSync(cmd, {
+              //       shell: true,
+              //       stdio: "inherit",
+              //     });
+              //     if (result.status !== 0) {
+              //       log.debug(`Command failed with status ${result.status}`);
+              //       if (result.error) console.log(result.error);
+              //       EXIT(1);
+              //     }
+              //     return resolve();
+              //   };
+              //   exec(`unzip -o "${out}" -d "${cacheDir}"`);
             } else {
               compressing.zip.uncompress(out, cacheDir).then(() => resolve());
             }

diff --git a/test/fixture/preview.js b/test/fixture/preview.js