New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zip doesn't work, app compression? #1328

Closed

indexofrefraction opened this issue Dec 22, 2024 · 1 comment · Fixed by #1333 or #1325

$@indexofrefraction$

indexofrefraction commented Dec 22, 2024

according to the docs zip: true should zip the outfolder, but that doesn't work

and btw .. it would be great to have an option to compress the app.nw / package.nw folders

Package version: 4.13.7
Operating System: macos Sonoma 14.5 (arm64)
Node version: 22.12.0
NW.js version: 0.94.0

Collaborator

ayushmanchhabra commented Dec 23, 2024

Thanks for the bug report, will look into it soon

ayushmanchhabra mentioned this issue

fix(bld): await archiver.finalize #1333

Merged

ayushmanchhabra closed this as completed in #1333

ayushmanchhabra closed this as completed in

580668f

github-actions bot mentioned this issue

chore(main): release 4.13.8 #1325

Merged

ayushmanchhabra pushed a commit that referenced this issue


          chore(main): release 4.13.8 (#1325)

ce71ec8

🤖 I have created a release *beep* *boop*
---


##
[4.13.8](v4.13.7...v4.13.8)
(2025-01-01)


### Bug Fixes

* **bld:** await archiver.finalize
([#1333](#1333))
([580668f](580668f)),
closes [#1328](#1328)


### Chores

* **deps:** bump the npm group across 1 directory with 11 updates
([#1332](#1332))
([b9b96ff](b9b96ff))
* **docs:** clarify CJS usage
([d673459](d673459)),
closes [#1331](#1331)
* **docs:** clarify non-usage of srcDir in CLi interface
([1b61bd1](1b61bd1)),
closes [#1330](#1330)
* **docs:** fix CJS import usage example
([5f323df](5f323df)),
closes [#1331](#1331)
* **test:** download latest NW.js version for Linux demo app
([8c09908](8c09908)),
closes [#1324](#1324)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment