chore(get): refactor unzip symlink implementation #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushmanchhabra
force-pushed
the
chore/refactor-unzip-symlink
branch
2 times, most recently
from
fdab15a to
21a9032
Compare
ayushmanchhabra
force-pushed
the
chore/refactor-unzip-symlink
branch
from
21a9032 to
706d38a
Compare
ayushmanchhabra
added a commit
that referenced
this pull request
Feb 15, 2024
* Current implementation: write entry as file, check if entry is symlink, remove file and create symlink * Improved implementation: check if entry is symlink, stream entry to buffer, extract link target and create symlink. Otherwise, stream entry to file. Refs: #1030
ayushmanchhabra
pushed a commit
that referenced
this pull request
Feb 19, 2024
🤖 I have created a release *beep* *boop* --- ## [4.6.1](v4.6.0...v4.6.1) (2024-02-15) ### Chores * **ci:** add chores section to changelog ([#1028](#1028)) ([d630720](d630720)) * **ci:** fixup release please action ([#1032](#1032)) ([f9ae7cd](f9ae7cd)) * **ci:** remove `schema` prop ([33238b1](33238b1)) * **deps:** bump the gha group in /.github/workflows with 1 update ([70030df](70030df)) * **docs:** update PR template to simplify commit descriptions ([#1029](#1029)) ([6da9b89](6da9b89)) * **docs:** update readme and changelog ([63fd50b](63fd50b)) * fix remaining lint errors ([334ae74](334ae74)) * **get:** refactor implementation ([#1025](#1025)) ([72f65e1](72f65e1)) * **get:** refactor unzip symlink implementation ([#1030](#1030)) ([69661c3](69661c3)) * **get:** simplify symlink logic ([#1035](#1035)) ([4f64307](4f64307)), closes [#1030](#1030) * **release-please-action:** do not point to manifest file ([96eeec8](96eeec8)) * **release-please-action:** point to config and manifest ([0a6a44d](0a6a44d)) * **release-please:** correct path to package ([3719cee](3719cee)) * **release-please:** remove manifest ([23a16fb](23a16fb)) * **run:** mark run mode as deprecated ([#1027](#1027)) ([1115728](1115728)) * **test:** try adding chores to release notes ([#1031](#1031)) ([5cabc20](5cabc20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createSymlinksfunction workaroundRefs: overlookmotel/yauzl-promise#39 (comment)