Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): rename MacOS Helpers #955

Closed
wants to merge 37 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d4f0bc1
test: `npm run demo` for demo app
ayushmanchhabra Oct 1, 2023
b900bb9
test: use MacOS for demo
ayushmanchhabra Oct 1, 2023
d68b582
refactor(build): osx plist info
ayushmanchhabra Oct 1, 2023
186e3c4
feat(build): rename MacOS Helper apps
ayushmanchhabra Oct 1, 2023
0631375
chore: wip
ayushmanchhabra Oct 1, 2023
d82213c
fix: renaming helpers
ayushmanchhabra Oct 1, 2023
b85e334
test: import from file instead of package
ayushmanchhabra Oct 1, 2023
2448ae2
feat(build): update Helper Info.plist values
ayushmanchhabra Oct 1, 2023
6c96b56
test: update demo
ayushmanchhabra Oct 2, 2023
792bdb8
test: fix icon file path
ayushmanchhabra Oct 2, 2023
ed78e42
fix: lint
ayushmanchhabra Oct 2, 2023
84b2aa2
fix: rename `Contents/MacOS/nwjs` to `options.app.name`
ayushmanchhabra Oct 2, 2023
b172c98
fix: rename `Contents/MacOS/nwjs` to `options.app.name` again
ayushmanchhabra Oct 2, 2023
eaa0b4b
fix: rename Helper exe inside Contents/MacOS
ayushmanchhabra Oct 2, 2023
febf044
ci: test run demo app
ayushmanchhabra Oct 2, 2023
cd585dc
chore: unset `unzip` logic
ayushmanchhabra Oct 2, 2023
e9fda7f
fix: format
ayushmanchhabra Oct 5, 2023
e0fb3c8
Merge branch 'main' of github.com:nwutils/nw-builder into macos-helpers
ayushmanchhabra Oct 5, 2023
8882226
fix: format and lint
ayushmanchhabra Oct 5, 2023
446f218
chore: revert build.js to main impl
ayushmanchhabra Oct 5, 2023
2d512bd
test: set name to `demo` across demo app
ayushmanchhabra Oct 5, 2023
6746dc1
refactor: simplify plist update process
ayushmanchhabra Oct 5, 2023
159f020
refactor(build): simplify plist update process some more
ayushmanchhabra Oct 5, 2023
7c0b721
fix: format
ayushmanchhabra Oct 5, 2023
03a6b2a
feat: rename macos helpers
ayushmanchhabra Oct 5, 2023
554da1c
fix(fs): incorrect `readFile` call
ayushmanchhabra Oct 5, 2023
9dd2163
fix: code comment
ayushmanchhabra Oct 5, 2023
34e5e27
chore: add todo comment
ayushmanchhabra Oct 5, 2023
e12a52a
fix: merge conflicts
ayushmanchhabra Oct 16, 2023
9bfb2e6
fix: do not rely on symlinks
ayushmanchhabra Oct 16, 2023
b2e1c31
test: assert exe is renamed to `options.app.name`
ayushmanchhabra Oct 16, 2023
3c16f43
fix: format
ayushmanchhabra Oct 16, 2023
8adcd53
test: revert
ayushmanchhabra Oct 16, 2023
1bd0ed8
test: rename nwjs to `options.app.name`
ayushmanchhabra Oct 16, 2023
b21d3a0
test
ayushmanchhabra Oct 16, 2023
fdb4e2a
run tests
ayushmanchhabra Oct 16, 2023
f8f971e
test: rename `Contents/MacOS/nwjs` to `Contents/MacOS/${options.app.n…
ayushmanchhabra Oct 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"doc:dev": "concurrently --kill-others \"node .github/fswatch.config.js\" \"vitepress dev doc\"",
"doc:bld": "node .github/jsdoc.config.cjs && vitepress build doc",
"test:unit": "node --test test/unit/index.js",
"test:e2e": "node --test test/e2e/index.js",
"test:e2e": "node --test test/e2e/*.js",
"demo": "cd test/fixture && node demo.js"
},
"devDependencies": {
Expand Down
Loading
Loading