Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stream): decompression on macos #989

Closed
wants to merge 10 commits into from
Closed

fix(stream): decompression on macos #989

wants to merge 10 commits into from

Conversation

ayushmanchhabra
Copy link
Collaborator

Fixes: N/A

Description

  • Use Stream Promise API with yauzl-promise.

@ayushmanchhabra
Copy link
Collaborator Author

https://github.com/nwutils/nw-builder/actions/runs/7091596162/job/19301077432
@sysrage @zkrige Not sure why the stream is closing prematurely. Tested locally on Ubuntu 22 and Windows 11 and don't see this error happening. Could you verify if it happens on your local MacOS?

@ayushmanchhabra ayushmanchhabra changed the title fix(ci): stream handling for macos fix(stream): st handling for macos Dec 4, 2023
@ayushmanchhabra ayushmanchhabra changed the title fix(stream): st handling for macos fix(stream): decompresion on macos Dec 4, 2023
@ayushmanchhabra ayushmanchhabra changed the title fix(stream): decompresion on macos fix(stream): decompression on macos Dec 4, 2023
@zkrige
Copy link
Collaborator

zkrige commented Dec 5, 2023

I'm not sure why its closing early, but we should move away from yauzl for macOS anyways - it doesnt extract symlinks, so theres no point in keeping it

@ayushmanchhabra ayushmanchhabra deleted the fix/ci-macos branch December 6, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushmanchhabra @zkrige