Extract thread cache key handling #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getand
force-pushed
the
extract-thread-cache-key-handling
branch
from
430365b to
45b3c71
Compare
getand
force-pushed
the
extract-thread-cache-key-handling
branch
from
45b3c71 to
6badb77
Compare
a-berg-gs
reviewed
Nov 11, 2021
| NOTE: In order to avoid problems with threaded application servers you should always clear the cache key one your | ||
| threads once the request is finished using `NxtHttpClient.clear_thread_cache_key` to not have other threads use the | ||
| same cache key and thus use cached results across threads. | ||
|
|
There was a problem hiding this comment.
So before a thread could handle a request and then another but keep its cache?
There was a problem hiding this comment.
Basically if an application server reuses a thread the thread local variable need to be cleared so it's not bleeding into another request. Because the idea of caching per thread actually is to cache within a single request.
Co-authored-by: Andreas Berg <[email protected]>
Comment on lines
+22
to
+26
| Thread.current[THREAD_CACHE_KEY] ||= build_thread_cache_key | ||
| end | ||
|
|
||
| def clear_thread_cache_key | ||
| Thread.current[THREAD_CACHE_KEY] = nil |
There was a problem hiding this comment.
What do you think about using RequestStore gem?
lutfidemirci
approved these changes
Nov 23, 2021
|
Do we still need this, or can we close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for thread cache key clearing for threaded application servers