Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nice, unobtrusive GitHub-styled icon as button #3

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

Cito
Copy link
Contributor

@Cito Cito commented Sep 1, 2021

Includes the following changes:

  • text buttons replaced with icons
  • darker color while inactive for less distraction
  • also hide button until hovering over code block

Ported from jdbrice/obsidian-code-block-copy#13

Includes the following changes:

- text buttons replaced with icons
- darker color while inactive for less distraction
- also hide button until hovering over code block

Ported from jdbrice/obsidian-code-block-copy#13
@nyable nyable merged commit 7725a51 into nyable:master Sep 2, 2021
@nyable
Copy link
Owner

nyable commented Sep 2, 2021

Thanks for your pull request!Make the copy button more beautiful.

darker color while inactive for less distraction

Because the display effect seems to be a bit problematic under the light theme, I use --interactive-accent instead of --interactive-normal

@Cito Cito deleted the nice-button branch September 2, 2021 09:03
@Cito
Copy link
Contributor Author

Cito commented Sep 2, 2021

Thanks for merging. I have tried to improve colors a bit more in #6. The brightness filter is not ideal when you want to make things independent of dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants