Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate installs on join form submission when the apt matches #744

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

Andrew-Dickinson
Copy link
Member

I don't remember why we stopped doing this deduplication and if it was intentional.

If there was a good reason we stopped doing it, let's keep just the tests from this PR as a way to validate our expectations about this

Closes #549

@Andrew-Dickinson Andrew-Dickinson changed the title Deduplicate installs on join form submission Deduplicate installs on join form submission when the apt matches Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (e1d52ca) to head (d591248).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   94.87%   94.88%           
=======================================
  Files          89       89           
  Lines        3805     3809    +4     
=======================================
+ Hits         3610     3614    +4     
  Misses        195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillNilges
Copy link
Collaborator

WillNilges commented Nov 28, 2024

I'm pretty sure this was simply an oversight. It seems reasonable to me to not create a new install if the same person in the same building in the same unit fills out the join form again.

Can you explain what is meant by member_filled_out_the_join_form_long_ago_and_we_recycled_their_install_number? What does "recycling" an install number mean? Did you mean "node number"?

@Andrew-Dickinson
Copy link
Member Author

In this context, recycling just means the "spreadsheet row number" (which we imported as an install number due to the inactive status of that row at import time) was assigned as a network number to another install

In the sense that "node number" ~= "spreadsheet row number" I think that's correct, but it really is an install number in MeshDB parlance

@Andrew-Dickinson Andrew-Dickinson enabled auto-merge (squash) December 24, 2024 22:18
@Andrew-Dickinson Andrew-Dickinson merged commit 615e619 into main Dec 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't deduplicate installs in the join form if the install number is re-used as an NN
2 participants