Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send existingNetworkNumber to OSTicket only for Active nodes #767

Merged
merged 4 commits into from
Jan 18, 2025

Conversation

Andrew-Dickinson
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson commented Dec 3, 2024

Lydon wants to use this to send an email that doesn't ask for panos, so we would like to be sure that there is an Active node at their location rather than any node

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (b9367ae) to head (e051ec0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files          89       89           
  Lines        3816     3816           
=======================================
  Hits         3621     3621           
  Misses        195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-Dickinson Andrew-Dickinson enabled auto-merge (squash) January 18, 2025 02:46
@Andrew-Dickinson Andrew-Dickinson merged commit 832eb2e into main Jan 18, 2025
10 checks passed
@Andrew-Dickinson Andrew-Dickinson deleted the andrew/only-send-active-nodes branch January 18, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants